Change in osmo-ggsn[master]: gtp: Add new replacement cb_recovery2 for cb_recovery

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Jul 24 09:33:11 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10024 )

Change subject: gtp: Add new replacement cb_recovery2 for cb_recovery
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/10024/3/gtp/gtp.h
File gtp/gtp.h:

https://gerrit.osmocom.org/#/c/10024/3/gtp/gtp.h@274
PS3, Line 274: 	int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);
> ok, so we break ABI but we don't break API compatibility - that's not great but acceptable (and I se […]
We could move cb_recovery2 to the end of the struct since it is always accessed through pointers, so at least field access wouldn't change, but we'd still break the ABI.



-- 
To view, visit https://gerrit.osmocom.org/10024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53e92298f2f6b84d662a3300d922e8c2ccb178bc
Gerrit-Change-Number: 10024
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Jul 2018 09:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180724/39e6755f/attachment.htm>


More information about the gerrit-log mailing list