Change in osmo-bsc[master]: large refactoring: use FSMs for lchans; add inter-BSC HO

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jul 24 05:34:30 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9671 )

Change subject: large refactoring: use FSMs for lchans; add inter-BSC HO
......................................................................


Patch Set 28:

(1 comment)

https://gerrit.osmocom.org/#/c/9671/28/src/osmo-bsc/handover_fsm.c
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/#/c/9671/28/src/osmo-bsc/handover_fsm.c@352
PS28, Line 352: 	{
> @laforge, your opinion is against these inner scopes, but I don't really see a need to remove them. […]
it's just something I've never seen in the kernel, and we use kernel coding style in Osmocom.  So my argument is "consistency with existing code base and documented coding style". Yes, "if" there was an if, I wouldn't flag it.

we also add another indent level without any need for it, reducing the usable part of the line.

A quick look at the function without reading it from top to bottom makes me think this is some kind of condition/branch/loop due to that extra indent, only to then discover no, this is normal, un-conditional "main body" of the function.



-- 
To view, visit https://gerrit.osmocom.org/9671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e3f918295daa83274a4cf803f046979f284366
Gerrit-Change-Number: 9671
Gerrit-PatchSet: 28
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Jul 2018 05:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180724/62073a92/attachment.htm>


More information about the gerrit-log mailing list