Change in libosmocore[master]: logging: Fix logging level all

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Jul 23 13:42:21 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10116 )

Change subject: logging: Fix logging level all
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/10116/1/src/logging.c
File src/logging.c:

https://gerrit.osmocom.org/#/c/10116/1/src/logging.c@70
PS1, Line 70: 0
Feel free to use 'LOGL_UNSET' here ;)


https://gerrit.osmocom.org/#/c/10116/1/src/logging.c@721
PS1, Line 721: 	for (i = 0; i < osmo_log_info->num_cat; i++) {
Would be great to have a comment here, what this loop
is actually doing? Resetting all categories to 'unset'?

As I understand, setting:

  logging level all error
  logging level l1p notice
  logging level l1c error

and then:

  logging level all notice

would reset log_levels for both 'l1p' and 'l1c' to 'unset'?

What if I need to change to global logging level without
resetting the existing categories? I think we can introduce
something like this:

  logging level all notice [reset]

or like this:

  logging level global notice // Only changes the global
  logging level all notice // Resets all categories to 'notice'

What do you think?


https://gerrit.osmocom.org/#/c/10116/1/src/vty/logging_vty.c
File src/vty/logging_vty.c:

https://gerrit.osmocom.org/#/c/10116/1/src/vty/logging_vty.c@a283
PS1, Line 283: 
Probably, it makes sense to keep informing user that 'everything' is deprecated, but now is reused as 'unset'...



-- 
To view, visit https://gerrit.osmocom.org/10116
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f50ad8d6fd038398f7d751287417505c8dcdeff
Gerrit-Change-Number: 10116
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 13:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180723/89d3fe6b/attachment.htm>


More information about the gerrit-log mailing list