Change in osmo-bsc[master]: move RSL and RR related functions to abis_rsl.[hc]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 23 01:40:25 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9669 )

Change subject: move RSL and RR related functions to abis_rsl.[hc]
......................................................................


Patch Set 12:

Rationale:

gsm_04_08_utils.c and bsc_api.c contain functions that rx/tx messages over Abis RSL. Some small programs/tests that pull in gsm_04_08_utils.c then pull in the entire Abis dependencies.

Looking at it again, the functions of 04_08_utils.c used elsewhere than abis_rsl.c are:

gsm_net_update_ctype() in bsc_vty.c, bsc_init.c

gsm48_create_loc_upd_rej() in osmo_bsc_api.c

gsm48_multirate_config() in osmo_bsc_api.c

gsm48_extract_mi() in bsc_msg_filter.c

gsm48_paging_extract_mi() in osmo_bsc_api.c and bsc_msg_filter.c

str_to_imsi() in pcu_sock.c, paging.c, bsc_vty.c

(weird dependency example: msg_filter test needing Abis RSL, ...)

Maybe it makes more sense to move some of those out. I think "_utils" still is a misnomer for the central Abis RR implementation, could become abis_rr.c, but we don't really need to rename the file.

Then there is bsc_api.c, that appears to have been a kitchen sink for everything and anything. We removed struct bsc_api already. Do we agree on moving bsc_api.c's RR functions? If gsm_04_08_utils.c is the main "RR" file, then maybe handle_rr_ho_*() and gsm_04_08_rcvmsg should move from bsc_api.c to gsm_04_08_utils.c instead of abis_rsl.c?

(The only functions left in bsc_api.c are gsm0808_page() and gsm0808_cipher_mode(), maybe they can move to the callers, paging.c and osmo_bsc_bssap.c, to completely drop bsc_api.c)


-- 
To view, visit https://gerrit.osmocom.org/9669
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8ee334145bf7bc3a601d395ea7ab9b2009b61c7
Gerrit-Change-Number: 9669
Gerrit-PatchSet: 12
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 01:40:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180723/aaf2889a/attachment.htm>


More information about the gerrit-log mailing list