Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id (2nd attempt)

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10098 )

Change subject: Move from libc random() to osmo_get_rand_id (2nd attempt)
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10098/1/src/host/layer23/src/mobile/utils.c
File src/host/layer23/src/mobile/utils.c:

https://gerrit.osmocom.org/#/c/10098/1/src/host/layer23/src/mobile/utils.c@37
PS1, Line 37: int mobile_random(void)
Just a few questions:

  - Why do we need int, and not unsigned int?
    It's written in description that return value starts from 0...

  - Why not to share this wrapper in 'src/host/layer23/src/common/utils.c'?
    This way some other fragmented parts would be able to use it, e.g. misc utils...



-- 
To view, visit https://gerrit.osmocom.org/10098
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd4be88c62bba1e9d954568e48f0c12a67ac182
Gerrit-Change-Number: 10098
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 22 Jul 2018 10:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180722/330c0cae/attachment.htm>