Change in osmo-ttcn3-hacks[master]: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 21 17:54:36 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10035 )

Change subject: sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo
......................................................................

sgsn: Remove uneeded f_gtpu_send in f_gtpu_xceive_mo

It's not needed for the functionality/scenario of f_gtpu_xceive_mo. It
probably was left in when creating it from f_gtpu_xceive_mo.

Change-Id: Ide226f8501c4598e2bfaa5f1ea62c3ff20807ce4
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index d7e956f..d76c182 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1117,12 +1117,12 @@
 	}
 }
 
+/* Transceive given 'payload' as MT message from Gb -> OsmoSGSN -> GTP */
 private function f_gtpu_xceive_mo(inout PdpActPars apars, octetstring payload) runs on BSSGP_ConnHdlr {
 	/* Send PDU via SNDCP/LLC/BSSGP/NS via simulated MS/PCU to the SGSN */
 	var GtpPeer peer := valueof(ts_GtpPeerU(apars.sgsn_ip_u));
 	var PDU_SN sndcp := valueof(ts_SN_UD(apars.nsapi, payload));
 	BSSGP.send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, 0));
-	f_gtpu_send(apars, payload);
 	/* Expect PDU via GTP from SGSN on simulated GGSN */
 	alt {
 	[] GTP.receive(tr_GTPU_GPDU(peer, apars.ggsn_tei_u, payload));

-- 
To view, visit https://gerrit.osmocom.org/10035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide226f8501c4598e2bfaa5f1ea62c3ff20807ce4
Gerrit-Change-Number: 10035
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180721/e3e0dba8/attachment.htm>


More information about the gerrit-log mailing list