Change in osmo-bsc[master]: fix handling of invalid pchan names in vty

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10026 )

Change subject: fix handling of invalid pchan names in vty
......................................................................

fix handling of invalid pchan names in vty

If an invalid phys_chan_config is specified in osmo-bsc.cfg, raise
a parsing error at program startup.

If an invalid phys_chan_config is specified in in the VTY while
the program is running, show a warning to inform the user that
the configuration change was not applied.

Change-Id: I97baa359464a0e94de2497bc9214b99ed2a24041
Related: OS#1876
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 57c5363..77a534d 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4032,8 +4032,10 @@
 	int pchanc;
 
 	pchanc = gsm_pchan_parse(argv[0]);
-	if (pchanc < 0)
-		return CMD_WARNING;
+	if (pchanc < 0) {
+		vty_out(vty, "Unknown physical channel name '%s'%s", argv[0], VTY_NEWLINE);
+		return CMD_ERR_NO_MATCH;
+	}
 
 	ts->pchan = pchanc;
 

-- 
To view, visit https://gerrit.osmocom.org/10026
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I97baa359464a0e94de2497bc9214b99ed2a24041
Gerrit-Change-Number: 10026
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180721/69a6ad0e/attachment.htm>