Change in osmo-bsc[master]: various logging: fix missing/extra newlines

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10059


Change subject: various logging: fix missing/extra newlines
......................................................................

various logging: fix missing/extra newlines

Change-Id: Id2619d0d45eb2686246c03643b4a578392a54cfe
---
M src/libfilter/bsc_msg_acc.c
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/handover_decision_2.c
M src/osmo-bsc/system_information.c
5 files changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/59/10059/1

diff --git a/src/libfilter/bsc_msg_acc.c b/src/libfilter/bsc_msg_acc.c
index 46077b3..de6c4d9 100644
--- a/src/libfilter/bsc_msg_acc.c
+++ b/src/libfilter/bsc_msg_acc.c
@@ -96,7 +96,7 @@
 
 	lst = talloc_zero(ctx, struct bsc_msg_acc_lst);
 	if (!lst) {
-		LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list");
+		LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list\n");
 		return NULL;
 	}
 
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index cb1cc56..d056bc4 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -1214,11 +1214,11 @@
 
 	/* go back to the start as we checked the whole filesize.. */
 	lseek(sw->fd, 0l, SEEK_SET);
-	LOGP(DNM, LOGL_NOTICE, "The ipaccess SDP header is not fully understood.\n"
-			       "There might be checksums in the file that are not\n"
-			       "verified and incomplete firmware might be flashed.\n"
-			       "There is absolutely no WARRANTY that flashing will\n"
-			       "work.\n");
+	LOGP(DNM, LOGL_NOTICE, "The ipaccess SDP header is not fully understood."
+			       " There might be checksums in the file that are not"
+			       " verified and incomplete firmware might be flashed."
+			       " There is absolutely no WARRANTY that flashing will"
+			       " work.\n");
 	return 0;
 }
 
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index ab3658d..bcc56bc 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -2351,7 +2351,7 @@
 		break;
 	}
 	LOGP(DRSL, LOGL_ERROR, "Cannot determine ip.access rtp payload type for "
-		"tch_mode == 0x%02x\n & lchan_type == %d",
+		"tch_mode == 0x%02x & lchan_type == %d\n",
 		lchan->tch_mode, lchan->type);
 	return 0;
 }
diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c
index e514b6c..826dcaa 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -1680,7 +1680,7 @@
 	struct gsm_subscriber_connection *conn = ho->old_lchan->conn;
 
 	if (!conn) {
-		LOGPHO(ho, LOGL_ERROR, "HO failure, but no conn");
+		LOGPHO(ho, LOGL_ERROR, "HO failure, but no conn\n");
 		return;
 	}
 
diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c
index d99153f..f810f52 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -556,7 +556,7 @@
 		return 0;
 
 	LOGP(DRR, LOGL_ERROR, "min_arfcn=%u, max_arfcn=%u, arfcns=%d "
-		"can not generate ARFCN list", min, max, arfcns);
+		"can not generate ARFCN list\n", min, max, arfcns);
 	return -EINVAL;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/10059
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2619d0d45eb2686246c03643b4a578392a54cfe
Gerrit-Change-Number: 10059
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/a7fd595f/attachment.htm>