This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10032 ) Change subject: vty: initialize termios before using it ...................................................................... Patch Set 1: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/10032/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/10032/1/src/vty/vty.c@1509 PS1, Line 1509: struct termios t = { 0 }; ( I like and often use the empty braces to indicate all members to be zero-initialized: struct termios t = {}; ) https://gerrit.osmocom.org/#/c/10032/1/src/vty/vty.c@1513 PS1, Line 1513: tcsetattr(vty_sock, TCSANOW, &t); (wow, what's up with the indenting here, lol) -- To view, visit https://gerrit.osmocom.org/10032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d165911fa3127afa8f836fa5c5c2e14a949474a Gerrit-Change-Number: 10032 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jul 2018 00:40:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/5953c7fa/attachment.htm>