Change in osmo-bsc[master]: fix handling of invalid pchan names in vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jul 18 23:15:09 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10026 )

Change subject: fix handling of invalid pchan names in vty
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/10026/1/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/10026/1/src/osmo-bsc/bsc_vty.c@4037
PS1, Line 4037: 		if (vty->type == VTY_FILE)
nice, with CMD_ERR_NO_MATCH, you've found a way of aborting program startup without aborting a running application from telnet vty. For that you don't actually need to check vty->type == VTY_FILE, just always return CMD_ERR_NO_MATCH.

(Checking for VTY_FILE allows to exit(-1) or OSMO_ASSERT(false) except when in telnet mode, but CMD_ERR_NO_MATCH actually has exactly the desired effect, and my hint at VTY_FILE on redmine was just confusing you)

(only now do I actually fully realize that the entire issue exists only with uppercase pchan types, and that one gets proper command matching with the lower case ones; weird hysterical raisins I guess.)



-- 
To view, visit https://gerrit.osmocom.org/10026
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97baa359464a0e94de2497bc9214b99ed2a24041
Gerrit-Change-Number: 10026
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jul 2018 23:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180718/2d22e6ea/attachment.htm>


More information about the gerrit-log mailing list