Change in osmo-bsc[master]: codec_pref: move match_codec_pref() to separate c-file and add unit-test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Jul 17 11:37:38 UTC 2018


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/10010

to look at the new patch set (#8).

Change subject: codec_pref: move match_codec_pref() to separate c-file and add unit-test
......................................................................

codec_pref: move match_codec_pref() to separate c-file and add unit-test

At the moment there are three sources that may advertise a list of
supported audio codec/rate settings. There is the MS that advertises
advertises a speech codec list and the MSC that sends a channel type
information element over A and there are also settings in the bsc
configuration file that may restrict the codec/rate types that are
allowed to use.

The function match_codec_pref() looks at all of the three buckets and
selects a codec that satisfies all three. This is already a somewhat
complicated process, overit is very isolated, so lets give it its own
c-file.

Due to the lack of unit-tests it is very hard to make changes here so
lets add also unit-test to make sure that regressions are catched early.

- Put match_codec_pref() and all its helper functions into a separate
  c-file.
- Add a unit test.

Change-Id: Iabedfdcec8b99a319f2d57cbea45c5e36c7b6e29
Related: OS#3361
---
M configure.ac
M include/osmocom/bsc/Makefile.am
A include/osmocom/bsc/codec_pref.h
M src/osmo-bsc/Makefile.am
A src/osmo-bsc/codec_pref.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/Makefile.am
A tests/codec_pref/Makefile.am
A tests/codec_pref/codec_pref_test.c
A tests/codec_pref/codec_pref_test.ok
M tests/testsuite.at
11 files changed, 1,432 insertions(+), 160 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/10010/8
-- 
To view, visit https://gerrit.osmocom.org/10010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabedfdcec8b99a319f2d57cbea45c5e36c7b6e29
Gerrit-Change-Number: 10010
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180717/b223eb54/attachment.htm>


More information about the gerrit-log mailing list