Change in openbsc[master]: bsc: ctrl: Avoid sending back received ERROR msgs

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9981 )

Change subject: bsc: ctrl: Avoid sending back received ERROR msgs
......................................................................

bsc: ctrl: Avoid sending back received ERROR msgs

Change-Id: Ib5963e4d15a4a6b077d7a97fbbde6e5134c77e9a
---
M openbsc/src/osmo-bsc/osmo_bsc_msc.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/osmo-bsc/osmo_bsc_msc.c b/openbsc/src/osmo-bsc/osmo_bsc_msc.c
index 4395c3b..b179ff1 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_msc.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_msc.c
@@ -224,9 +224,10 @@
 {
 	int ret;
 	struct ctrl_cmd *cmd;
+	bool parse_failed;
 
-	cmd = ctrl_cmd_parse2(msc->msc_con, msg);
-	if (cmd->type == CTRL_TYPE_ERROR) {
+	cmd = ctrl_cmd_parse3(msc->msc_con, msg, &parse_failed);
+	if (cmd->type == CTRL_TYPE_ERROR && parse_failed) {
 		LOGP(DMSC, LOGL_ERROR, "Failed to parse control message.\n");
 
 		ctrl_cmd_send(&msc->msc_con->write_queue, cmd);

-- 
To view, visit https://gerrit.osmocom.org/9981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5963e4d15a4a6b077d7a97fbbde6e5134c77e9a
Gerrit-Change-Number: 9981
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180717/f67aca00/attachment.htm>