Change in osmo-ggsn[master]: gtp: Avoid freeing pdp contexts during DEL CTX REQ

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jul 16 20:54:54 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10006 )

Change subject: gtp: Avoid freeing pdp contexts during DEL CTX REQ
......................................................................


Patch Set 1: Code-Review-1

I'm not entirely happy about this, as it introudces a huge semantic break of the API/ABI.  This means that old users of libgtp will still compile + link fine against new libtp, but then at runtime fail in strange ways during PDP DEL CTX REQ.

This is quite different from "syntactic" API breakage which will make compilation of old apps against new library fail.  We can also not resolve this with libversion, IMHO.

Please try to consider this and come up with a solution that will (preferably) make old apps still compile against new libgtp versions, or (if really neccessary) make such old applications break when attempting to compile against new libgtp.


-- 
To view, visit https://gerrit.osmocom.org/10006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29d366253bb98dcba328c7ce8aa3e4daf8f75e6c
Gerrit-Change-Number: 10006
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 16 Jul 2018 20:54:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/31a3f800/attachment.htm>


More information about the gerrit-log mailing list