This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9998 ) Change subject: bsc: fix f_gen_ass_req(): populate codec list ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9998/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9998/1//COMMIT_MSG@16 PS1, Line 16: TC_assignment_csd() : * TC_assignment_ctm() are you sure a circuit switched data call (which has no voice, and hence no voice codecs) needs/wants a Speech Codec List IE? I don't recall the details, but I *think* the speech codec list IE is intentionally not set by f_gen_ass_req() so the callers must set it, _if they want one_. In the end, it's a question of API design/policy, and I don't care either way. We just need to make sure that only voice call assignments have the IEs that relate to voice calls (only) -- To view, visit https://gerrit.osmocom.org/9998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f Gerrit-Change-Number: 9998 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 17:51:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/6bed7c4c/attachment.htm>