Change in libosmocore[master]: coding: Correctly count bits when decoding EDGE bursts with MCS >= 7.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jul 16 08:26:24 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9997 )

Change subject: coding: Correctly count bits when decoding EDGE bursts with MCS >= 7.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

fine except for cosmetics

https://gerrit.osmocom.org/#/c/9997/2/src/coding/gsm0503_coding.c
File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/#/c/9997/2/src/coding/gsm0503_coding.c@997
PS2, Line 997: if (n_errors) *n_errors += n_errors2;
             : 		if (n_bits_total) *n_bits_total += n_bits_total2;
please observe coding style (separate line for if clause and statements inside the clause)



-- 
To view, visit https://gerrit.osmocom.org/9997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I560de192212dae4705054a1665726369b83d213a
Gerrit-Change-Number: 9997
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 16 Jul 2018 08:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/b4b7aaf6/attachment.htm>


More information about the gerrit-log mailing list