Change in osmo-bts[master]: rsl: Use value_string to print encryption algo name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Jul 15 22:06:38 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9902 )

Change subject: rsl: Use value_string to print encryption algo name
......................................................................

rsl: Use value_string to print encryption algo name

Change-Id: I8303364270e73718e57f8efc2f375817b9496ffc
---
M src/common/rsl.c
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Holger Freyther: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 8bbf73c..9295240 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -865,12 +865,13 @@
 {
 	int rc;
 	struct gsm_bts *bts = lchan->ts->trx->bts;
+	const char *ciph_name = get_value_string(gsm0808_chosen_enc_alg_names, *val);
 
 	/* check if the encryption algorithm sent by BSC is supported! */
 	rc = bts_supports_cipher(bts, *val);
 	if (rc != 1) {
-		LOGP(DRSL, LOGL_ERROR, "%s: BTS doesn't support cipher 0x%02x\n",
-			gsm_lchan_name(lchan), *val);
+		LOGP(DRSL, LOGL_ERROR, "%s: BTS doesn't support cipher %s\n",
+			gsm_lchan_name(lchan), ciph_name);
 		return -EINVAL;
 	}
 
@@ -886,8 +887,8 @@
 	if (lchan->encr.key_len > sizeof(lchan->encr.key))
 		lchan->encr.key_len = sizeof(lchan->encr.key);
 	memcpy(lchan->encr.key, val, lchan->encr.key_len);
-	DEBUGP(DRSL, "%s: Setting lchan cipher algorithm 0x%02x\n",
-		gsm_lchan_name(lchan), lchan->encr.alg_id);
+	DEBUGP(DRSL, "%s: Setting lchan cipher algorithm %s\n",
+		gsm_lchan_name(lchan), ciph_name);
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/9902
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8303364270e73718e57f8efc2f375817b9496ffc
Gerrit-Change-Number: 9902
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180715/e112f875/attachment.htm>


More information about the gerrit-log mailing list