Change in osmo-ggsn[master]: gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Jul 13 17:06:56 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9988


Change subject: gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn
......................................................................

gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn

According to 3GPP TS 29.060 section "7.3.5
Delete PDP Context Request", both directions are valid in both GSNs.

This allows osmo-sgsn receive delete ctx indication (cb_delete_context)
in order to implement GGSN initiated requests.

Change-Id: I6927c07be4ddf74defe338d01d947056e15cd14d
---
M gtp/gtp.c
1 file changed, 4 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/88/9988/1

diff --git a/gtp/gtp.c b/gtp/gtp.c
index ac3ec99..5b83d20 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2830,8 +2830,7 @@
 
 		if ((gsn->mode == GTP_MODE_GGSN) &&
 		    ((pheader->type == GTP_CREATE_PDP_RSP) ||
-		     (pheader->type == GTP_UPDATE_PDP_RSP) ||
-		     (pheader->type == GTP_DELETE_PDP_RSP))) {
+		     (pheader->type == GTP_UPDATE_PDP_RSP))) {
 			gsn->unexpect++;
 			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
 				    status,
@@ -2842,8 +2841,7 @@
 
 		if ((gsn->mode == GTP_MODE_SGSN) &&
 		    ((pheader->type == GTP_CREATE_PDP_REQ) ||
-		     (pheader->type == GTP_UPDATE_PDP_REQ) ||
-		     (pheader->type == GTP_DELETE_PDP_REQ))) {
+		     (pheader->type == GTP_UPDATE_PDP_REQ))) {
 			gsn->unexpect++;
 			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
 				    status,
@@ -3009,8 +3007,7 @@
 
 		if ((gsn->mode == GTP_MODE_GGSN) &&
 		    ((pheader->type == GTP_CREATE_PDP_RSP) ||
-		     (pheader->type == GTP_UPDATE_PDP_RSP) ||
-		     (pheader->type == GTP_DELETE_PDP_RSP))) {
+		     (pheader->type == GTP_UPDATE_PDP_RSP))) {
 			gsn->unexpect++;
 			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
 				    status,
@@ -3021,8 +3018,7 @@
 
 		if ((gsn->mode == GTP_MODE_SGSN) &&
 		    ((pheader->type == GTP_CREATE_PDP_REQ) ||
-		     (pheader->type == GTP_UPDATE_PDP_REQ) ||
-		     (pheader->type == GTP_DELETE_PDP_REQ))) {
+		     (pheader->type == GTP_UPDATE_PDP_REQ))) {
 			gsn->unexpect++;
 			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
 				    status,

-- 
To view, visit https://gerrit.osmocom.org/9988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6927c07be4ddf74defe338d01d947056e15cd14d
Gerrit-Change-Number: 9988
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180713/8a907387/attachment.htm>


More information about the gerrit-log mailing list