This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9934 ) Change subject: osmo-sgsn: ping GGSN periodically and check for restart counter ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/9934/2/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/9934/2/include/osmocom/sgsn/gprs_sgsn.h@357 PS2, Line 357: int32_t echo_interval; I would just use an "int" here, as this is what osmo_timer_schedule() uses https://gerrit.osmocom.org/#/c/9934/2/src/gprs/gprs_sgsn.c File src/gprs/gprs_sgsn.c: https://gerrit.osmocom.org/#/c/9934/2/src/gprs/gprs_sgsn.c@736 PS2, Line 736: osmo_timer_schedule(&ggc->echo_timer, ggc->echo_interval, 0); is this some gerrit visualization issue or is there one tab too much? https://gerrit.osmocom.org/#/c/9934/2/src/gprs/gprs_sgsn.c@743 PS2, Line 743: osmo_timer_del(&ggc->echo_timer); same as above -- To view, visit https://gerrit.osmocom.org/9934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d714726785407859f26bbef052cd0efc28e8dae Gerrit-Change-Number: 9934 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Fri, 13 Jul 2018 05:32:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180713/2694f6a3/attachment.htm>