Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 )

Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/9979/2/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c
File openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c:

https://gerrit.osmocom.org/#/c/9979/2/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c@90
PS2, Line 90: 	if (id_str[0] == '\0' || endptr[0] != '\0')
> EINVAL (not in C99) The given base contains an unsupported value. […]
"In  particular,  if *nptr is not '\0' but **endptr is '\0' on return, the entire
       string is valid."



-- 
To view, visit https://gerrit.osmocom.org/9979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Jul 2018 18:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/331dd7b1/attachment.htm>