Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jul 12 18:28:09 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9979 )

Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9979/2/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c
File openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c:

https://gerrit.osmocom.org/#/c/9979/2/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c@90
PS2, Line 90: 	if (id_str[0] == '\0' || endptr[0] != '\0')
> what about errno?
No need to check it for our purposes here as far as I understand.



-- 
To view, visit https://gerrit.osmocom.org/9979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994
Gerrit-Change-Number: 9979
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Jul 2018 18:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/2c548d02/attachment.htm>


More information about the gerrit-log mailing list