Change in libosmocore[master]: gsm_08_08: gsm0808_permitted_speech does not have value strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Jul 12 16:23:42 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9976


Change subject: gsm_08_08: gsm0808_permitted_speech does not have value strings
......................................................................

gsm_08_08: gsm0808_permitted_speech does not have value strings

enum gsm0808_permitted_speech does not have any value strings. Lets
add value strings to make debugging easier.

Change-Id: I5b5612a5df2758b0137a34c17f7c8c2b3f07c806
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
3 files changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/9976/1

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h
index db5f7fa..bd5705f 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -430,6 +430,10 @@
 	GSM0808_PERM_HR6	= 0x45, /*!< OHR AMR */
 };
 
+extern const struct value_string gsm0808_permitted_speech_names[];
+static inline const char *gsm0808_permitted_speech_name(enum gsm0808_permitted_speech val)
+{ return get_value_string(gsm0808_permitted_speech_names, val); }
+
 /*! 3GPP TS 48.008, 3.2.2.103 Speech Codec Type */
 enum gsm0808_speech_codec_type {
 	GSM0808_SCT_FR1	= 0x0, /*!< GSM FR */
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 625de81..a26addd 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1153,6 +1153,20 @@
 	{ 0, NULL }
 };
 
+const struct value_string gsm0808_permitted_speech_names[] = {
+	{ GSM0808_PERM_FR1, "FR1" },
+	{ GSM0808_PERM_FR2, "FR2" },
+	{ GSM0808_PERM_FR3, "FR3" },
+	{ GSM0808_PERM_FR4, "FR4" },
+	{ GSM0808_PERM_FR5, "FR5" },
+	{ GSM0808_PERM_HR1, "HR1" },
+	{ GSM0808_PERM_HR2, "HR2" },
+	{ GSM0808_PERM_HR3, "HR3" },
+	{ GSM0808_PERM_HR4, "HR4" },
+	{ GSM0808_PERM_HR6, "HR6" },
+	{ 0, NULL }
+};
+
 static const struct value_string gsm0808_cause_names[] = {
 	{ GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE, "RADIO INTERFACE MESSAGE FAILURE" },
 	{ GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, "RADIO INTERFACE FAILURE" },
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 96779d2..5eed5b5 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -201,6 +201,7 @@
 gsm0808_chan_type_to_speech_codec;
 gsm0808_speech_codec_from_chan_type;
 gsm0808_speech_codec_type_names;
+gsm0808_permitted_speech_names;
 gsm0808_channel_type_name;
 gsm0808_lcls_config_names;
 gsm0808_lcls_control_names;

-- 
To view, visit https://gerrit.osmocom.org/9976
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b5612a5df2758b0137a34c17f7c8c2b3f07c806
Gerrit-Change-Number: 9976
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/b69c9d45/attachment.htm>


More information about the gerrit-log mailing list