Change in simtrace2[master]: make adc2uv common

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Kévin Redon gerrit-no-reply at lists.osmocom.org
Wed Jul 11 18:48:33 UTC 2018


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/9964

to look at the new patch set (#3).

Change subject: make adc2uv common
......................................................................

make adc2uv common

when building the trace app for the simtrace board gcc was outputing
the following error:
libboard/common/source/boardver_adc.c:20:17: warning: 'adc2uv' defined but not used [-Wunused-function]
 static uint32_t adc2uv(uint16_t adc)

adc2uv is used by qmod, and defined in two places:
in boardver_adc.c and mode_cardemu.c.

this change will have adc2uv only defined in boardver_adc.c and make
available in the header to be used by mode_cardemu.c.

Change-Id: I8a772638fa8dd02d8bc8b7631de5af5a22647c55
---
M firmware/libboard/common/include/boardver_adc.h
M firmware/libboard/common/source/boardver_adc.c
M firmware/libcommon/source/mode_cardemu.c
3 files changed, 3 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/64/9964/3
-- 
To view, visit https://gerrit.osmocom.org/9964
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a772638fa8dd02d8bc8b7631de5af5a22647c55
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180711/64ee6c1a/attachment.htm>


More information about the gerrit-log mailing list