Change in libosmo-sccp[master]: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jul 11 13:52:34 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9952 )

Change subject: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr
......................................................................


Patch Set 1:

yes, sure, but it seems the intention of the API is to have IEI name definitions based on the xua_msg_type, so that the IEIs can differ based on the underlying transport layer. I'd love to use that, but all I get is a uint8_t msg_type from the xua_msg, and can't find API to get to the struct xua_msg_type from that. Publishing sua_iei_names bypasses the apparently carefully crafted API to avoid exactly that. (See where sua_iei_names gets used)


-- 
To view, visit https://gerrit.osmocom.org/9952
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64adb31129684b2eb66fff581040017ce2f6d163
Gerrit-Change-Number: 9952
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jul 2018 13:52:34 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180711/6c8ba8c9/attachment.htm>


More information about the gerrit-log mailing list