This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9942
Change subject: tbf: Replace '.' in counter names with ':'
......................................................................
tbf: Replace '.' in counter names with ':'
The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.
Change-Id: Ieb7496e1a30ab4f2bfe36c7b664dcdc034010a15
---
M src/tbf.cpp
1 file changed, 32 insertions(+), 32 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/42/9942/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 76137df..71057db 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -98,49 +98,49 @@
};
static const struct rate_ctr_desc tbf_ctr_description[] = {
- { "rlc.nacked", "RLC Nacked " },
+ { "rlc:nacked", "RLC Nacked " },
};
static const struct rate_ctr_desc tbf_dl_gprs_ctr_description[] = {
- { "gprs.downlink.cs1", "CS1 " },
- { "gprs.downlink.cs2", "CS2 " },
- { "gprs.downlink.cs3", "CS3 " },
- { "gprs.downlink.cs4", "CS4 " },
+ { "gprs:downlink:cs1", "CS1 " },
+ { "gprs:downlink:cs2", "CS2 " },
+ { "gprs:downlink:cs3", "CS3 " },
+ { "gprs:downlink:cs4", "CS4 " },
};
static const struct rate_ctr_desc tbf_dl_egprs_ctr_description[] = {
- { "egprs.downlink.mcs1", "MCS1 " },
- { "egprs.downlink.mcs2", "MCS2 " },
- { "egprs.downlink.mcs3", "MCS3 " },
- { "egprs.downlink.mcs4", "MCS4 " },
- { "egprs.downlink.mcs5", "MCS5 " },
- { "egprs.downlink.mcs6", "MCS6 " },
- { "egprs.downlink.mcs7", "MCS7 " },
- { "egprs.downlink.mcs8", "MCS8 " },
- { "egprs.downlink.mcs9", "MCS9 " },
+ { "egprs:downlink:mcs1", "MCS1 " },
+ { "egprs:downlink:mcs2", "MCS2 " },
+ { "egprs:downlink:mcs3", "MCS3 " },
+ { "egprs:downlink:mcs4", "MCS4 " },
+ { "egprs:downlink:mcs5", "MCS5 " },
+ { "egprs:downlink:mcs6", "MCS6 " },
+ { "egprs:downlink:mcs7", "MCS7 " },
+ { "egprs:downlink:mcs8", "MCS8 " },
+ { "egprs:downlink:mcs9", "MCS9 " },
};
static const struct rate_ctr_desc tbf_ul_gprs_ctr_description[] = {
- { "gprs.uplink.cs1", "CS1 " },
- { "gprs.uplink.cs2", "CS2 " },
- { "gprs.uplink.cs3", "CS3 " },
- { "gprs.uplink.cs4", "CS4 " },
+ { "gprs:uplink:cs1", "CS1 " },
+ { "gprs:uplink:cs2", "CS2 " },
+ { "gprs:uplink:cs3", "CS3 " },
+ { "gprs:uplink:cs4", "CS4 " },
};
static const struct rate_ctr_desc tbf_ul_egprs_ctr_description[] = {
- { "egprs.uplink.mcs1", "MCS1 " },
- { "egprs.uplink.mcs2", "MCS2 " },
- { "egprs.uplink.mcs3", "MCS3 " },
- { "egprs.uplink.mcs4", "MCS4 " },
- { "egprs.uplink.mcs5", "MCS5 " },
- { "egprs.uplink.mcs6", "MCS6 " },
- { "egprs.uplink.mcs7", "MCS7 " },
- { "egprs.uplink.mcs8", "MCS8 " },
- { "egprs.uplink.mcs9", "MCS9 " },
+ { "egprs:uplink:mcs1", "MCS1 " },
+ { "egprs:uplink:mcs2", "MCS2 " },
+ { "egprs:uplink:mcs3", "MCS3 " },
+ { "egprs:uplink:mcs4", "MCS4 " },
+ { "egprs:uplink:mcs5", "MCS5 " },
+ { "egprs:uplink:mcs6", "MCS6 " },
+ { "egprs:uplink:mcs7", "MCS7 " },
+ { "egprs:uplink:mcs8", "MCS8 " },
+ { "egprs:uplink:mcs9", "MCS9 " },
};
static const struct rate_ctr_group_desc tbf_ctrg_desc = {
- "pcu.tbf",
+ "pcu:tbf",
"TBF Statistics",
OSMO_STATS_CLASS_SUBSCRIBER,
ARRAY_SIZE(tbf_ctr_description),
@@ -148,7 +148,7 @@
};
static const struct rate_ctr_group_desc tbf_dl_gprs_ctrg_desc = {
- "tbf.gprs",
+ "tbf:gprs",
"Data Blocks",
OSMO_STATS_CLASS_SUBSCRIBER,
ARRAY_SIZE(tbf_dl_gprs_ctr_description),
@@ -156,7 +156,7 @@
};
static const struct rate_ctr_group_desc tbf_dl_egprs_ctrg_desc = {
- "tbf.egprs",
+ "tbf:egprs",
"Data Blocks",
OSMO_STATS_CLASS_SUBSCRIBER,
ARRAY_SIZE(tbf_dl_egprs_ctr_description),
@@ -164,7 +164,7 @@
};
static const struct rate_ctr_group_desc tbf_ul_gprs_ctrg_desc = {
- "tbf.gprs",
+ "tbf:gprs",
"Data Blocks",
OSMO_STATS_CLASS_SUBSCRIBER,
ARRAY_SIZE(tbf_ul_gprs_ctr_description),
@@ -172,7 +172,7 @@
};
static const struct rate_ctr_group_desc tbf_ul_egprs_ctrg_desc = {
- "tbf.egprs",
+ "tbf:egprs",
"Data Blocks",
OSMO_STATS_CLASS_SUBSCRIBER,
ARRAY_SIZE(tbf_ul_egprs_ctr_description),
--
To view, visit https://gerrit.osmocom.org/9942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb7496e1a30ab4f2bfe36c7b664dcdc034010a15
Gerrit-Change-Number: 9942
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180710/84d49fd5/attachment.htm>