Change in gapk[master]: build: fix packaging problems and make distcheck happy

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9930 )

Change subject: build: fix packaging problems and make distcheck happy
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am
File libgsmhr/Makefile.am:

https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am@15
PS1, Line 15: 	$(srcdir)/fetch_sources.py "${REFSRC_PATH}"
Since this is in EXTRA_DIST I bet this should be $(builddir) instead of srcdir.


https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am
File tests/Makefile.am:

https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am@82
PS1, Line 82: 	ref-files \
If it's a directory I'd be more easy to follow if you add a "/" at the end.


https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at
File tests/testsuite.at:

https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at@15
PS1, Line 15: 		$abs_srcdir/io/io_sample.txt],
I think we are missing EXTRA_DIT and adding those there, like we do in all other projects with .ok files.



-- 
To view, visit https://gerrit.osmocom.org/9930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb8f6a2a81f9b75c8c6c5db443b0e7be02bc4153
Gerrit-Change-Number: 9930
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Jul 2018 17:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180709/9a675303/attachment.htm>