This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgHolger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9510 )
Change subject: bsc-nat: ipaccess_auth_bsc: Close bsc conn immediately on bad format received
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/9510/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/#/c/9510/1//COMMIT_MSG@13
PS1, Line 13: Previously, authentication would still not be accepted but the
: connection would be staying alive for a while until id_timeout timer
: triggers. Let's close the connection immediately instead, this way BSC
: side can see quickly something is wrong with what it is sending.
That is because our memcmp is not constant time and I didn't want to build an oracle. ;)
--
To view, visit https://gerrit.osmocom.org/9510
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I972961b8967076c56c607f98c2360054144951e4
Gerrit-Change-Number: 9510
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Holger Freyther <holger at freyther.de>
Gerrit-Comment-Date: Sat, 07 Jul 2018 13:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180707/db44b4e9/attachment.htm>