Change in osmo-ttcn3-hacks[master]: BTS_Tests: Call mtc.stop in f_shutdown() to fix sporadic test failures

[daniel]

daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/9889 )

Change subject: BTS_Tests: Call mtc.stop in f_shutdown() to fix sporadic test failures
......................................................................

BTS_Tests: Call mtc.stop in f_shutdown() to fix sporadic test failures

mtc.stop cleanly shuts down a testcase. This avoids errors influencing
the result after the test completed (such as ports being shutdown with
messages arriving on them causing a dynamic test case error).

Change-Id: I0f6e10006f46db0d68796c7082497af90f74cd07
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index b77a70a..dbb8313 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -341,10 +341,8 @@
 }
 
 function f_shutdown() runs on test_CT {
-	/* shut down all "externally interfaced" components first to avoid unclean shutdown */
-	vc_IPA.stop;
-	vc_RSL.stop;
-	f_ipa_ctrl_stop();
+	/* mtc.stop cleanly stops testcase execution to avoid unclean shutdown */
+	mtc.stop;
 }
 
 /* Attach L1CTL to master test_CT (classic tests, non-handler mode) */

-- 
To view, visit https://gerrit.osmocom.org/9889
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f6e10006f46db0d68796c7082497af90f74cd07
Gerrit-Change-Number: 9889
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180705/fe9bbf21/attachment.htm>