Change in simtrace2[master]: qmod: Add 'e' command for erasing the EEPROM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Kévin Redon gerrit-no-reply at lists.osmocom.org
Wed Jul 4 12:23:13 UTC 2018


Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9858 )

Change subject: qmod: Add 'e' command for erasing the EEPROM
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9858/1/firmware/libboard/qmod/source/board_qmod.c
File firmware/libboard/qmod/source/board_qmod.c:

https://gerrit.osmocom.org/#/c/9858/1/firmware/libboard/qmod/source/board_qmod.c@103
PS1, Line 103: --;
this can cause an endless loop, halted by the watchdog.
alternative: print error message instead and continue with erasing the rest (or stop erasing)



-- 
To view, visit https://gerrit.osmocom.org/9858
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cb0db568dd3e9d796829bf0019d63048612998
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Jul 2018 12:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/031b1f44/attachment.htm>


More information about the gerrit-log mailing list