Change in simtrace2[master]: LED: add short LED pulse blinking pattern

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 4 11:56:18 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9864 )

Change subject: LED: add short LED pulse blinking pattern
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9864/3/firmware/libboard/common/source/led.c
File firmware/libboard/common/source/led.c:

https://gerrit.osmocom.org/#/c/9864/3/firmware/libboard/common/source/led.c@20
PS3, Line 20: 	else
this appears to change the on/off logic for the LEDs.  That's a logically separate change from "adding a fast blinking pattern" and it's not mentioned in the change log.



-- 
To view, visit https://gerrit.osmocom.org/9864
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fdc2f902a3b92da6aa9b9c8500abae8a2f79447
Gerrit-Change-Number: 9864
Gerrit-PatchSet: 3
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 04 Jul 2018 11:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/61ca5861/attachment.htm>


More information about the gerrit-log mailing list