Change in simtrace2[master]: echo all command characters entered on serial console

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 4 01:56:20 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9857 )

Change subject: echo all command characters entered on serial console
......................................................................

echo all command characters entered on serial console

This is required to make python pexpect.fdexpect happy, as it
requires that all characters are echo-ed back in order to detect
when the output of a given command starts.

Change-Id: I73b24e43f6c8b86a2766aba67d8307c184448aa0
---
M firmware/apps/cardem/main.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c
index a80c498..2114901 100644
--- a/firmware/apps/cardem/main.c
+++ b/firmware/apps/cardem/main.c
@@ -108,6 +108,8 @@
 		return;
 
 	ch = UART_GetChar();
+	/* We must echo the character to make python fdexpect happy, whcih we use in factory testing */
+	fputc(ch, stdout);
 
 	board_exec_dbg_cmd(ch);
 }

-- 
To view, visit https://gerrit.osmocom.org/9857
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73b24e43f6c8b86a2766aba67d8307c184448aa0
Gerrit-Change-Number: 9857
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/9fe4d94a/attachment.htm>


More information about the gerrit-log mailing list