This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9855 ) Change subject: sniffer: use ISR to store sniffed data in buffer, add ATR and PPS parsing, and PPS related FiDi update ...................................................................... Patch Set 1: Code-Review+1 (4 comments) https://gerrit.osmocom.org/#/c/9855/1/firmware/libcommon/source/sniffer.c File firmware/libcommon/source/sniffer.c: https://gerrit.osmocom.org/#/c/9855/1/firmware/libcommon/source/sniffer.c@208 PS1, Line 208: >= it's not super critical (i.e. not required to merge this), but in general, osmocom coding style uses spaces around comparison operators https://gerrit.osmocom.org/#/c/9855/1/firmware/libcommon/source/sniffer.c@234 PS1, Line 234: == cosmetic: spaces https://gerrit.osmocom.org/#/c/9855/1/firmware/libcommon/source/sniffer.c@240 PS1, Line 240: & also here, spaces, and in all incarnations below. https://gerrit.osmocom.org/#/c/9855/1/firmware/libcommon/source/sniffer.c@364 PS1, Line 364: rbuf_reset(&sniff_buffer); /* reset buffer for new communication */ indent level wrong, more critical than the cosmetic spaces above. -- To view, visit https://gerrit.osmocom.org/9855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b38ce1d80e370fda6aa181e959ba3f1286bb922 Gerrit-Change-Number: 9855 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Jul 2018 17:01:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/9cf844d1/attachment.htm>