Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9653 )

Change subject: introduce a TTCN3 test suite for SCCP
......................................................................


Patch Set 1: Code-Review-1

(9 comments)

the test is importing/building tons of modules which it doesn't need, this should be cleaned up first.

https://gerrit.osmocom.org/#/c/9653/1/sccp/SCCP_Tests.ttcn
File sccp/SCCP_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9653/1/sccp/SCCP_Tests.ttcn@37
PS1, Line 37: import from BSSAP_Adapter all;
there is nothing BSSAP specific in this test, I'm wondering why it usees BSSAP_Adapter?


https://gerrit.osmocom.org/#/c/9653/1/sccp/SCCP_Tests.ttcn@60
PS1, Line 60: function f_init(BSSAP_Configuration cfg) runs on MTC_CT {
this appears to be the only BSSAP related type used, but we're not really using the BSSAP_Adapter.  I think this is misleading and I'd prefer if code that tests SCCP only imports no modules and/or types that relate to BSSAP


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh
File sccp/gen_links.sh:

https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@49
PS1, Line 49: DIR=$BASEDIR/titan.ProtocolModules.BSSMAP_v11.2.0/src
            : FILES="BSSAP_Types.ttcn"
            : gen_links $DIR $FILES
this can go


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@53
PS1, Line 53: DIR=$BASEDIR/titan.ProtocolModules.ROSE/src
            : FILES="Remote_Operations_Generic_ROS_PDUs.asn  Remote_Operations_Information_Objects.asn"
            : gen_links $DIR $FILES
            : 
            : DIR=$BASEDIR/titan.ProtocolModules.MAP/src
            : FILES="MAP_ApplicationContexts.asn MAP_CH_DataTypes.asn MAP_CallHandlingOperations.asn MAP_CommonDataTypes.asn MAP_DialogueInformation.asn MAP_ER_DataTypes.asn MAP_EncDec.cc MAP_Errors.asn MAP_GR_DataTypes.asn MAP_Group_Call_Operations.asn MAP_LCS_DataTypes.asn MAP_LocationServiceOperations.asn MAP_MS_DataTypes.asn MAP_MobileServiceOperations.asn MAP_OM_DataTypes.asn MAP_OperationAndMaintenanceOperations.asn MAP_PDU_Defs.asn MAP_Protocol.asn MAP_SM_DataTypes.asn MAP_SS_Code.asn MAP_SS_DataTypes.asn MAP_ShortMessageServiceOperations.asn MAP_SupplementaryServiceOperations.asn MAP_TS_Code.asn MAP_Types.ttcn "
            : FILES+="MAP_BS_Code.asn MAP_ExtensionDataTypes.asn MobileDomainDefinitions.asn"
            : gen_links $DIR $FILES
            : 
            : DIR=$BASEDIR/titan.ProtocolModules.MobileL3_v13.4.0/src
            : FILES="MobileL3_CC_Types.ttcn MobileL3_CommonIE_Types.ttcn MobileL3_GMM_SM_Types.ttcn MobileL3_MM_Types.ttcn MobileL3_RRM_Types.ttcn MobileL3_SMS_Types.ttcn MobileL3_SS_Types.ttcn MobileL3_Types.ttcn "
            : FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"
            : gen_links $DIR $FILES
            : 
            : DIR=$BASEDIR/titan.ProtocolModules.SDP/src
            : FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h SDP_parse_parser.h SDP_parser.l
            : SDP_parser.y lex.SDP_parse_.c"
            : gen_links $DIR $FILES
this can all go


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@78
PS1, Line 78: MNCC_Types.ttcn MNCC_EncDec.cc MNCC_CodecPort.ttcn mncc.h MNCC_Emulation.ttcn
this can go


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@79
PS1, Line 79: GSUP_Types.ttcn GSUP_Emulation.ttcn
this can go


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@80
PS1, Line 80: L3_Templates.ttcn L3_Common.ttcn
this can go


https://gerrit.osmocom.org/#/c/9653/1/sccp/gen_links.sh@81
PS1, Line 81: BSSMAP_Emulation.ttcn BSSAP_CodecPort.ttcn BSSMAP_Templates.ttcn BSSAP_Adapter.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_Emulation.ttcn "
            : FILES+="MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunctDef.cc "
            : gen_links $DIR $FILES
this can all go


https://gerrit.osmocom.org/#/c/9653/1/sccp/regen_makefile.sh
File sccp/regen_makefile.sh:

https://gerrit.osmocom.org/#/c/9653/1/sccp/regen_makefile.sh@5
PS1, Line 5: -DIPA_EMULATION_MGCP -DIPA_EMULATION_GSUP -DIPA_EMULATION_SCCP
those three should be removed, none of this is used here.



-- 
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Jul 2018 11:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/b5005275/attachment.htm>