This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6197/1/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: Line 118: #define OSMO_GSUP_COPY_IMSI(msg, _imsi) osmo_strlcpy((msg)->imsi, _imsi, GSM23003_IMSI_MAX_DIGITS + 2) why not a sizeof((msg)->imsi)? And why not actually a more generic helper that would work for any static array, unrelated to IMSIs or even unerlated to GSUP? something like OSMO_STRLCPY_ARRAY(array, source) which would automatically expand to an sizeof(array)? -- To view, visit https://gerrit.osmocom.org/6197 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes