This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged. Change subject: Revert "aoip_smpp: Disable check in esme_ms_sms_storeforward due to known issue" ...................................................................... Revert "aoip_smpp: Disable check in esme_ms_sms_storeforward due to known issue" This reverts commit 4a22ac7d2c0b24dba1939760121381e83827aa57. Issue has been fixed in OS#2354, osmo-msc 1e67fea7ba5c6336066b78f98a28ab33b05c36c4. Change-Id: I83d857c639db35abcd05bc87db9962d092c10eca --- M suites/aoip_smpp/esme_ms_sms_storeforward.py 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Pau Espin Pedrol: Looks good to me, approved Jenkins Builder: Verified diff --git a/suites/aoip_smpp/esme_ms_sms_storeforward.py b/suites/aoip_smpp/esme_ms_sms_storeforward.py index 9effe6d..543170e 100755 --- a/suites/aoip_smpp/esme_ms_sms_storeforward.py +++ b/suites/aoip_smpp/esme_ms_sms_storeforward.py @@ -42,18 +42,17 @@ msg = Sms(esme.msisdn, wrong_msisdn, 'smpp message with wrong dest') esme.run_method_expect_failure(SMPP_ESME_RINVDSTADR, esme.sms_send_wait_resp, msg, esme.MSGMODE_STOREFORWARD) -# Disabled due to known issue, see ticket OsmoSMSC #2354 -#print('sending sms, it will be stored...') -#msg = Sms(esme.msisdn, ms.msisdn, 'smpp send not-yet-registered message') -#umref = esme.sms_send_wait_resp(msg, esme.MSGMODE_STOREFORWARD, receipt=True) +print('sending sms, it will be stored...') +msg = Sms(esme.msisdn, ms.msisdn, 'smpp send not-yet-registered message') +umref = esme.sms_send_wait_resp(msg, esme.MSGMODE_STOREFORWARD, receipt=True) print('MS registers and will receive the SMS...') ms.connect(msc.mcc_mnc()) wait(ms.is_connected, msc.mcc_mnc()) wait(msc.subscriber_attached, ms) -#wait(ms.sms_was_received, msg) -#print('Waiting to receive and consume sms receipt with reference', umref) -#wait(esme.receipt_was_received, umref) +wait(ms.sms_was_received, msg) +print('Waiting to receive and consume sms receipt with reference', umref) +wait(esme.receipt_was_received, umref) print('checking MS can receive SMS while registered...') msg = Sms(esme.msisdn, ms.msisdn, 'smpp send already-registered message') -- To view, visit https://gerrit.osmocom.org/6150 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83d857c639db35abcd05bc87db9962d092c10eca Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>