osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 26 18:22:49 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6097/1/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:

Line 97: 		const struct bts_cm *cm; /* Table with supp. ch rate/mode combinations */
if this is alway an array that needs to be as large as MAX_PCHAN_T, then why not simply have it as a static array here?  Allowing it to be dynamically allocated just makes it harder to use, as somebody could allocate a too small array, and the generic code has no way of knowing the size of that array.


-- 
To view, visit https://gerrit.osmocom.org/6097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b222b7ab19ece90591718bc562b3a8c5e02023
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list