[PATCH] osmo-pcu[master]: Use explicit type for pcu_lsb()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Jan 26 17:50:47 UTC 2018


Review at  https://gerrit.osmocom.org/6105

Use explicit type for pcu_lsb()

It#s only used for byte-long input su we can specify input and output
types explicitly.

Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
---
M src/pcu_utils.h
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/6105/1

diff --git a/src/pcu_utils.h b/src/pcu_utils.h
index 298bb32..aab8d55 100644
--- a/src/pcu_utils.h
+++ b/src/pcu_utils.h
@@ -40,8 +40,7 @@
 	return __builtin_popcount(x);
 }
 
-template <typename T>
-inline T pcu_lsb(T x)
+inline uint8_t pcu_lsb(uint8_t x)
 {
 	return x & -x;
 }

-- 
To view, visit https://gerrit.osmocom.org/6105
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list