[MERGED] osmo-bsc[master]: Improve an error message in page_lai_and_lac()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Improve an error message in page_lai_and_lac()
......................................................................


Improve an error message in page_lai_and_lac()

This error message is now contained in a loop, and the current iteration
does not know whether paging will fail entirely or if later iterations
will succeed. Update the error message accordingly.
This also makes the error message consistent with the one in page_cgi().

Change-Id: I8ec229702343343dedcbb242b6d0ed170c858511
---
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/bssap/bssap_test.err
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 799cb46..67ff230 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -412,7 +412,7 @@
 				     mi_string, lac);
 			}
 		} else {
-			LOGP(DMSC, LOGL_DEBUG, "Not paging IMSI %s: MCC/MNC in Cell Identifier List "
+			LOGP(DMSC, LOGL_DEBUG, "Paging IMSI %s: MCC/MNC in Cell Identifier List "
 			     "(%d/%d) do not match our network (%d/%d)\n", mi_string, mcc, mnc,
 			     msc->network->country_code, msc->network->network_code);
 		}
diff --git a/tests/bssap/bssap_test.err b/tests/bssap/bssap_test.err
index abe1def..18bfbca 100644
--- a/tests/bssap/bssap_test.err
+++ b/tests/bssap/bssap_test.err
@@ -16,7 +16,7 @@
 2:
 DMSC Rx MSC UDT: 00 19 52 08 08 59 51 20 69 00 07 43 94 09 04 01 08 44 60 1a 06 04 15 f5 49 00 65 
 DMSC Rx MSC UDT BSSMAP PAGING
-DMSC Not paging IMSI 515029600703449: MCC/MNC in Cell Identifier List (515/94) do not match our network (1/1)
+DMSC Paging IMSI 515029600703449: MCC/MNC in Cell Identifier List (515/94) do not match our network (1/1)
 bsc_handle_udt() returned 0
 
 3:

-- 
To view, visit https://gerrit.osmocom.org/6063
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ec229702343343dedcbb242b6d0ed170c858511
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder