[PATCH] osmo-ggsn[master]: gtp.c: Log unsupported GTP version number

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jan 25 20:13:00 UTC 2018


Review at  https://gerrit.osmocom.org/6068

gtp.c: Log unsupported GTP version number

Change-Id: Idbc6e4c912b958bde5916b87ec53c3c4db70bee0
---
M gtp/gtp.c
1 file changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/6068/1

diff --git a/gtp/gtp.c b/gtp/gtp.c
index f513b9b..53b38de 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2802,8 +2802,8 @@
 		/* supported on this port */
 		if (version > 0) {
 			gsn->unsup++;
-			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
-				    status, "Unsupported GTP version\n");
+			GTP_LOGPKG(LOGL_ERROR, &peer, buffer, status,
+				"Unsupported GTP version %"PRIu8"\n", version);
 			gtp_unsup_req(gsn, 0, &peer, gsn->fd0, buffer, status);	/* 29.60: 11.1.1 */
 			continue;
 		}
@@ -2945,8 +2945,8 @@
 		/* Version must be no larger than GTP 1 */
 		if (version > 1) {
 			gsn->unsup++;
-			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
-				    status, "Unsupported GTP version\n");
+			GTP_LOGPKG(LOGL_ERROR, &peer, buffer, status,
+				"Unsupported GTP version %"PRIu8"\n", version);
 			gtp_unsup_req(gsn, version, &peer, fd, buffer, status);
 			/*29.60: 11.1.1 */
 			continue;
@@ -2958,8 +2958,8 @@
 		/* the message */
 		if (version < 1) {
 			gsn->unsup++;
-			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
-				    status, "Unsupported GTP version\n");
+			GTP_LOGPKG(LOGL_ERROR, &peer, buffer, status,
+				"Unsupported GTP version %"PRIu8"\n", version);
 			continue;
 		}
 
@@ -3123,8 +3123,8 @@
 		/* Version must be no larger than GTP 1 */
 		if (version > 1) {
 			gsn->unsup++;
-			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
-				    status, "Unsupported GTP version\n");
+			GTP_LOGPKG(LOGL_ERROR, &peer, buffer, status,
+				"Unsupported GTP version %"PRIu8"\n", version);
 			gtp_unsup_req(gsn, 1, &peer, gsn->fd1c, buffer, status);	/*29.60: 11.1.1 */
 			continue;
 		}
@@ -3135,8 +3135,8 @@
 		/* the message */
 		if (version < 1) {
 			gsn->unsup++;
-			GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
-				    status, "Unsupported GTP version\n");
+			GTP_LOGPKG(LOGL_ERROR, &peer, buffer, status,
+				"Unsupported GTP version %"PRIu8"\n", version);
 			continue;
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/6068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbc6e4c912b958bde5916b87ec53c3c4db70bee0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list