[PATCH] libosmocore[master]: Apply fixes suggested by shellcheck

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 24 12:16:37 UTC 2018


Review at  https://gerrit.osmocom.org/6012

Apply fixes suggested by shellcheck

Change-Id: Ic33fcc707a2913dbc4c7c23ee35ba4c8bc8a3a89
---
M contrib/jenkins_arch.sh
M contrib/jenkins_common.sh
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/6012/1

diff --git a/contrib/jenkins_arch.sh b/contrib/jenkins_arch.sh
index bac9278..5bf4bd3 100755
--- a/contrib/jenkins_arch.sh
+++ b/contrib/jenkins_arch.sh
@@ -4,7 +4,7 @@
 
 arch="$1"
 
-if [ "x$arch" == "x" ]; then
+if [ "x$arch" = "x" ]; then
 	echo "Error: You have to specify the architecture as first argument, e.g. $0 amd64"
 	exit 2
 fi
diff --git a/contrib/jenkins_common.sh b/contrib/jenkins_common.sh
index fa1d544..41c7fb4 100644
--- a/contrib/jenkins_common.sh
+++ b/contrib/jenkins_common.sh
@@ -28,5 +28,5 @@
 }
 
 run_make() {
-    $MAKE $PARALLEL_MAKE check || cat-testlogs.sh
+    $MAKE "$PARALLEL_MAKE" check || cat-testlogs.sh
 }

-- 
To view, visit https://gerrit.osmocom.org/6012
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic33fcc707a2913dbc4c7c23ee35ba4c8bc8a3a89
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list