[PATCH] osmo-pcu[master]: Remove ASAN preprocessor warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 24 09:50:53 UTC 2018


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6001

to look at the new patch set (#2).

Remove ASAN preprocessor warning

We have ASAN integrated into CI tests directly so there's no need in
additional manual warnings at compile time.

Change-Id: Idaabb4203a282be6779d7ab29de3f827b0ca6462
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/01/6001/2

diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index a86e09d..371392e 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -964,10 +964,10 @@
 
 	/* FIXME: move this to libgb: btsctx_free() */
 	llist_del(&the_pcu.bctx->list);
-#warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless"
-#if 0
-	talloc_free(the_pcu.bctx);
-#endif
+
+	if (the_pcu.bctx)
+		talloc_free(the_pcu.bctx);
+
 	the_pcu.bctx = NULL;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/6001
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaabb4203a282be6779d7ab29de3f827b0ca6462
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list