[MERGED] osmo-bsc[master]: HO: fix: increase the number of measurement report history t...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 19 22:09:26 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: HO: fix: increase the number of measurement report history to 10
......................................................................


HO: fix: increase the number of measurement report history to 10

If we want to average over up to 10 measurement reports (as configurable
at VTY), we need a history of at least 10 measurements.

Change-Id: Ia7cfac073bdc464092ca3e51dec319ac30401dd1
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/gsm_data_shared.h
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index c09d546..6659b72 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -50,6 +50,8 @@
 #define MAX_NEIGH_MEAS		10
 /* Maximum size of the averaging window for neighbor cells */
 #define MAX_WIN_NEIGH_AVG	10
+/* Maximum number of report history we store */
+#define MAX_MEAS_REP		10
 
 /* processed neighbor measurements for one cell */
 struct neigh_meas_proc {
diff --git a/include/osmocom/bsc/gsm_data_shared.h b/include/osmocom/bsc/gsm_data_shared.h
index fed3494..86c5ca9 100644
--- a/include/osmocom/bsc/gsm_data_shared.h
+++ b/include/osmocom/bsc/gsm_data_shared.h
@@ -266,7 +266,7 @@
 	struct neigh_meas_proc neigh_meas[MAX_NEIGH_MEAS];
 
 	/* cache of last measurement reports on this lchan */
-	struct gsm_meas_rep meas_rep[6];
+	struct gsm_meas_rep meas_rep[MAX_MEAS_REP];
 	int meas_rep_idx;
 	int meas_rep_count;
 

-- 
To view, visit https://gerrit.osmocom.org/5911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7cfac073bdc464092ca3e51dec319ac30401dd1
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list