This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: client/common: move constant MGCP_ENDPOINT_MAXLEN ...................................................................... client/common: move constant MGCP_ENDPOINT_MAXLEN MGCP_ENDPOINT_MAXLEN is currently only defined for the mgcp client, since this is in general a common parameter it should be moved to mgcp_common.h so that both sides can use it. Change-Id: I9e1c52aa5ebd83b2d9e5178ea24cb27d96cb7ddd --- M include/osmocom/mgcp/mgcp_common.h M include/osmocom/mgcp_client/mgcp_client.h 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/mgcp/mgcp_common.h b/include/osmocom/mgcp/mgcp_common.h index 29dc458..7684936 100644 --- a/include/osmocom/mgcp/mgcp_common.h +++ b/include/osmocom/mgcp/mgcp_common.h @@ -72,4 +72,8 @@ * (see also RFC3435 2.1.3.2 Names of Connections) */ #define MGCP_CONN_ID_LENGTH 32+1 +/* String length of Endpoint Identifiers. +/ (see also RFC3435 section 3.2.1.3) */ +#define MGCP_ENDPOINT_MAXLEN (255*2+1+1) + #endif diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 4caf656..882c908 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -55,9 +55,6 @@ #define MGCP_MSG_PRESENCE_AUDIO_PORT 0x0010 #define MGCP_MSG_PRESENCE_CONN_MODE 0x0020 -/* See also RFC3435 section 3.2.1.3 */ -#define MGCP_ENDPOINT_MAXLEN (255*2+1+1) - struct mgcp_msg { enum mgcp_verb verb; /* See MGCP_MSG_PRESENCE_* constants */ -- To view, visit https://gerrit.osmocom.org/5877 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e1c52aa5ebd83b2d9e5178ea24cb27d96cb7ddd Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder