This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 3:
Here's my opinion:
- I don't think it's necessary to automatically enable other flags when using --with-sysmobts. Both configure flags do different things. I'd at most print a warning if --with is detected and --enable is not enabled. In any case, after your change you make it automatically enabled for sysmobts but not for lc15.
- Keeping --with-symobts instead of --with-sysmobts-header is fine to maintain similar structure as for lc15.
- Passing -I. when --with-sysmobts is not set is really ugly. Best would be having a variable SYSMOBTS_L1H_CPPFLAGS = "-I${INCL_HEADERS" or = "" if not set, then using that one.
--
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0416a9f4c428189cd9c3909c8bd016ca2908128a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No