libosmocore[master]: tests: fix LDADD: link libosmovty from current build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Jan 19 00:16:00 UTC 2018


Patch Set 2:

> > could you clarify?
 > 
 > It's documented in https://www.gnu.org/software/automake/manual/html_node/Linking.html
 > In a nutshell, LDADD applies to all the programs, prog_LDADD
 > applies single program. So having only "prog_LDADD = $(LDADD)" is
 > confusing and redundant.

The question is whether prog_LDADD overrides or includes LDADD.
If it overrides, we still need to add it explicitly *if* we have a prog_LDADD.

"you can use the prog_LDADD variable [...] to override LDADD. If this variable exists for a given program, then that program is not linked using LDADD."

so only a

  prog_LDADD = $(LDADD)

is wrong, and a

  prog_LDADD = $(LDADD) other_things

is still necessary.

-- 
To view, visit https://gerrit.osmocom.org/5844
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id084e6e6efd25cd62b1bd7a4fc7c5985c39130c6
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list