[PATCH] osmo-iuh[master]: hnbap: log errors on decoding/encoding HNB-REGISTER msgs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 18 18:01:31 UTC 2018


Review at  https://gerrit.osmocom.org/5883

hnbap: log errors on decoding/encoding HNB-REGISTER msgs

Change-Id: I3c039267fa2cc047c5678bcfe4a603f70c21cdd1
---
M src/hnbgw_hnbap.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/83/5883/1

diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 2746c21..8fba13c 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -63,6 +63,8 @@
 	memset(&accept_out, 0, sizeof(accept_out));
 	rc = hnbap_encode_hnbregisteraccepties(&accept_out,  &accept);
 	if (rc < 0) {
+		LOGP(DHNBAP, LOGL_ERROR, "Failure to encode HNB-REGISTER-ACCEPT to %s: rc=%d\n",
+		     ctx->identity_info, rc);
 		return rc;
 	}
 
@@ -370,8 +372,11 @@
 	int rc;
 
 	rc = hnbap_decode_hnbregisterrequesties(&ies, in);
-	if (rc < 0)
+	if (rc < 0) {
+		LOGP(DHNBAP, LOGL_ERROR, "Failure to decode HNB-REGISTER-REQ from %s: rc=%d\n",
+		     ctx->identity_info, rc);
 		return rc;
+	}
 
 	/* copy all identity parameters from the message to ctx */
 	asn1_strncpy(ctx->identity_info, &ies.hnB_Identity.hNB_Identity_Info,

-- 
To view, visit https://gerrit.osmocom.org/5883
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c039267fa2cc047c5678bcfe4a603f70c21cdd1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list