This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 9: Code-Review-1 (6 comments) I think it's good having 2 separate options (enable-sysmobts, with-sysmobts), but it may be a good idea having a more explicit name like --with-sysmobts-headers or alike. Please fix the CPPFLAGS->CFLAGS stuff or explain why is it done like this. https://gerrit.osmocom.org/#/c/5818/9/configure.ac File configure.ac: Line 77: CPPFLAGS="$CPPFLAGS -I$SYSMOBTS_INCDIR -I$srcdir/include $LIBOSMOCORE_CFLAGS" Why CPPFLAGS and not CFLAGS? Line 82: CPPFLAGS=$oldCPPFLAGS same https://gerrit.osmocom.org/#/c/5818/9/contrib/jenkins_sysmobts.sh File contrib/jenkins_sysmobts.sh: Line 19: configure_flags="--with-sysmobts=$inst/include/ --enable-sysmocom-bts" Sound more natural for me first enabling it, then specifying the headers path, but it really doesn't matter :P https://gerrit.osmocom.org/#/c/5818/9/src/osmo-bts-sysmo/Makefile.am File src/osmo-bts-sysmo/Makefile.am: Line 1: AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(SYSMOBTS_INCDIR) agaion why cppflags and not cflags? https://gerrit.osmocom.org/#/c/5818/9/tests/misc/Makefile.am File tests/misc/Makefile.am: Line 2: AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOCODEC_CFLAGS) $(LIBOSMOTRAU_CFLAGS) $(LIBOSMOABIS_CFLAGS) In here CFLAGS are used and not CPPFLAGS. https://gerrit.osmocom.org/#/c/5818/9/tests/sysmobts/Makefile.am File tests/sysmobts/Makefile.am: Line 1: AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src/osmo-bts-sysmo -I$(SYSMOBTS_INCDIR) again CPPFLAGS -- To view, visit https://gerrit.osmocom.org/5818 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94ea8bad8b410550f72ee6a0408f42f6bd8b6cac Gerrit-PatchSet: 9 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes