libosmocore[master]: tests: fix LDADD: link libosmovty from current build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 17 23:35:11 UTC 2018


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/5844/1/tests/Makefile.am
File tests/Makefile.am:

Line 5: 	$(top_builddir)/src/vty/libosmovty.la \
> Seems like unrelated cosmetic change, but we shouldn't consider it merge bl
This is the main change of this patch. It is not cosmetic. It adds the locally built libosmovty.la to all test programs' linkages. Or did I miss something?


Line 151: vty_vty_test_LDADD = $(LDADD)
> That's unnecessary: LDADD is used by default so you can just remove the lin
This is following the pattern present in this file. e.g. see in line 146, same thing.

Hold on, *you* are the author of using LDADD like a local var, only last october.
http://git.osmocom.org/libosmocore/commit/?id=ba1059c173ac8f4845464c4f91d1890898f729a0

I'm not entirely sure whether a foo_LDADD then overrides or adds to the global LDADD... could you clarify?

Would it be ok with you to fix LDADD in a separate patch?


-- 
To view, visit https://gerrit.osmocom.org/5844
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id084e6e6efd25cd62b1bd7a4fc7c5985c39130c6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list