[MERGED] osmo-pcu[master]: Set V_N and V_B to known initial state

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jan 17 15:57:26 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: Set V_N and V_B to known initial state
......................................................................


Set V_N and V_B to known initial state

Reset V_N and V_B in UL/DL window class constructors to make sure we
always start from known initial state.

Related: OS#1759
Change-Id: I8e14ffa913b49c5394229220de9165cdfaabdf19
Fixes: CID70468, CID70469.
---
M src/rlc.h
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/rlc.h b/src/rlc.h
index fcc3edb..aac6b13 100644
--- a/src/rlc.h
+++ b/src/rlc.h
@@ -506,6 +506,7 @@
 	: m_v_s(0)
 	, m_v_a(0)
 {
+	reset();
 }
 
 inline const uint16_t gprs_rlc_dl_window::v_s() const
@@ -552,6 +553,7 @@
 	: m_v_r(0)
 	, m_v_q(0)
 {
+	m_v_n.reset();
 }
 
 inline bool gprs_rlc_ul_window::is_in_window(uint16_t bsn) const

-- 
To view, visit https://gerrit.osmocom.org/5786
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e14ffa913b49c5394229220de9165cdfaabdf19
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list