osmo-bts[master]: Fix test dependencies

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jan 16 13:55:12 UTC 2018


Patch Set 7: Code-Review-1

(2 comments)

would be nice to split this patch

https://gerrit.osmocom.org/#/c/5818/5/configure.ac
File configure.ac:

Line 62: AC_MSG_RESULT([$enable_sysmobts_calib])
With this patch it seems that this alone does not work:

  ./configure --with-sysmobts=foo

and that the old invocation

  ./configure --enable-sysmocom-bts

also no longer works on its own?

I think...

* we should keep the old --enable-sysmocom-bts option so we don't produce build fallout everywhere. It should yield exactly the previous behavior:
* we need a $sysmobts_incdir default so that --enable-sysmocom-bts works without issuing --with-sysmobts=.
* when --with-sysmobts was passed, $enable_sysmocom_bts should also be set to yes.


https://gerrit.osmocom.org/#/c/5818/5/contrib/sysmobts-calib/Makefile.am
File contrib/sysmobts-calib/Makefile.am:

Line 2: AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS)
shouldn't this also include the sysmobts header CFLAGS?


-- 
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ea8bad8b410550f72ee6a0408f42f6bd8b6cac
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list