This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 5: (2 comments) General note: the comments on already merged patches are very easy to miss. Unless there's smth really wrong with the patch,it's better to make follow-up patch/ticket/email to make sure it's not lost accidentally. https://gerrit.osmocom.org/#/c/5652/5/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: Line 256: gsm48_encode_ra((struct gsm48_ra_id *)buf, raid); > This code could cause unaligned access on some hardware platforms because w Neat, feel free to send the fix in a separate patch. Although I think we first have to actually hit the issue and than fix it. Which hw are you referring to? https://gerrit.osmocom.org/#/c/5652/5/src/gsm/gsm48.c File src/gsm/gsm48.c: Line 703: > Why was the comment removed? Without the comment (mnc < 100) becomes less o To me the comment clarified nothing - I still have to look into spec to understand it. I think reference to particular spec paragraph is more helpful. -- To view, visit https://gerrit.osmocom.org/5652 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74 Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes